From: Avi Kivity <avi@redhat.com>
To: Glauber Costa <glommer@redhat.com>
Cc: kvm@vger.kernel.org, aliguori@us.ibm.com
Subject: Re: [PATCH] provide a kvm_qemu_memory_alias() function
Date: Wed, 01 Oct 2008 10:38:15 +0300 [thread overview]
Message-ID: <48E328E7.4050802@redhat.com> (raw)
In-Reply-To: <1222811248-28360-2-git-send-email-glommer@redhat.com>
Glauber Costa wrote:
> Following the pattern we already do, provide a qemu_kvm wrapper to
> the memory aliases x86 functions. Reason is that we don't want to have
> references to the context spread over qemu.
>
> The destroy alias function is completely removed from libkvm/libkvm.c,
> since no one in the code base uses it directly.
>
>
> -int kvm_destroy_memory_alias(kvm_context_t kvm, uint64_t phys_start)
> -{
> - return kvm_create_memory_alias(kvm, phys_start, 0, 0);
> -}
> -
>
This exists so that readers don't have to wander why you're calling
kvm_create_memory_alias when you actually want to destroy one.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2008-10-01 7:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-30 21:47 [PATCH 0/2] --disable-kvm currently not working Glauber Costa
2008-09-30 21:47 ` [PATCH] provide a kvm_qemu_memory_alias() function Glauber Costa
2008-10-01 7:38 ` Avi Kivity [this message]
2008-10-01 13:55 ` Glauber Costa
2008-10-02 11:34 ` Avi Kivity
2008-09-30 21:47 ` [PATCH] fix compilation with --disable-kvm Glauber Costa
2008-09-30 22:06 ` [PATCH 0/2] --disable-kvm currently not working Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48E328E7.4050802@redhat.com \
--to=avi@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).