From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] provide a kvm_qemu_memory_alias() function Date: Wed, 01 Oct 2008 10:38:15 +0300 Message-ID: <48E328E7.4050802@redhat.com> References: <1222811248-28360-1-git-send-email-glommer@redhat.com> <1222811248-28360-2-git-send-email-glommer@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, aliguori@us.ibm.com To: Glauber Costa Return-path: Received: from mx2.redhat.com ([66.187.237.31]:35833 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751341AbYJAHjS (ORCPT ); Wed, 1 Oct 2008 03:39:18 -0400 In-Reply-To: <1222811248-28360-2-git-send-email-glommer@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Glauber Costa wrote: > Following the pattern we already do, provide a qemu_kvm wrapper to > the memory aliases x86 functions. Reason is that we don't want to have > references to the context spread over qemu. > > The destroy alias function is completely removed from libkvm/libkvm.c, > since no one in the code base uses it directly. > > > -int kvm_destroy_memory_alias(kvm_context_t kvm, uint64_t phys_start) > -{ > - return kvm_create_memory_alias(kvm, phys_start, 0, 0); > -} > - > This exists so that readers don't have to wander why you're calling kvm_create_memory_alias when you actually want to destroy one. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.