From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] [RESEND] VT-d: Fix iommu map page for mmio pages Date: Thu, 02 Oct 2008 15:29:38 +0300 Message-ID: <48E4BEB2.2000403@redhat.com> References: <0122C7C995D32147B66BF4F440D3016301C7D130@pdsmsx415.ccr.corp.intel.com> <48E4B707.5060702@redhat.com> <20081002120906.GE7289@il.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, "Kay, Allen M" , "Yang, Sheng" , Anthony Liguori , Amit Shah , Ben-Ami Yassour1 To: Muli Ben-Yehuda Return-path: Received: from mx2.redhat.com ([66.187.237.31]:46905 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753081AbYJBMav (ORCPT ); Thu, 2 Oct 2008 08:30:51 -0400 In-Reply-To: <20081002120906.GE7289@il.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: Muli Ben-Yehuda wrote: > On Thu, Oct 02, 2008 at 02:56:55PM +0300, Avi Kivity wrote: > >> Han, Weidong wrote: >> >>> From 61028d958dc7c57ee02de32ea89b025dccb9650d Mon Sep 17 00:00:00 2001 >>> From: Weidong Han >>> Date: Thu, 25 Sep 2008 23:32:02 +0800 >>> Subject: [PATCH] Map mmio pages into VT-d page table >>> >>> Assigned device could DMA to mmio pages, so also need to map mmio pages >>> into VT-d page table. >>> >>> >>> >> Well, Muli says at least on one machine this allows on guest to kill >> the host. What are we doing with this? >> >> If it's a hardware bug which is planned to be fixed (or is already >> fixed), great, but I need to know. >> > > Unfortunately I don't have access to the machine any more. We did > spend some time perusing the PCIe spec on this point, and although it > is pretty vague, the bottom line appears to be that peer-to-peer > traffic (device-to-device traffic) is allowed. I'm fine with applying > the patch. > Okay, I applied the patch. -- error compiling committee.c: too many arguments to function