From: Avi Kivity <avi@redhat.com>
To: "Zhang, Xiantao" <xiantao.zhang@intel.com>
Cc: kvm@vger.kernel.org, kvm-ia64@vger.kernel.org
Subject: Re: [PATCH 4/8]kvm: Split arch/x86/kvm/irq.c to two parts.
Date: Thu, 02 Oct 2008 16:04:16 +0300 [thread overview]
Message-ID: <48E4C6D0.5080703@redhat.com> (raw)
In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDC01A53DF6@pdsmsx415.ccr.corp.intel.com>
Zhang, Xiantao wrote:
> From bb0c01b997d16ff1c1b9b0e797a581577c385b54 Mon Sep 17 00:00:00 2001
> From: Xiantao Zhang <xiantao.zhang@intel.com>
> Date: Mon, 29 Sep 2008 10:59:30 +0800
> Subject: [PATCH] kvm: Split arch/x86/kvm/irq.c to two parts.
>
> Moving irq ack notification logic as common, and make
> it shared with ia64 side.
>
> 8 files changed, 14 insertions(+), 48 deletions(-)
>
Warning sign - more deletions than insertions.
> __kvm_migrate_pit_timer(vcpu);
> }
> -
> -/* This should be called with the kvm->lock mutex held */
> -void kvm_set_irq(struct kvm *kvm, int irq, int level)
> -{
> - /* Not possible to detect if the guest uses the PIC or the
> - * IOAPIC. So set the bit in both. The guest will ignore
> - * writes to the unused one.
> - */
> - kvm_ioapic_set_irq(kvm->arch.vioapic, irq, level);
> - kvm_pic_set_irq(pic_irqchip(kvm), irq, level);
> -}
> -
> -void kvm_notify_acked_irq(struct kvm *kvm, unsigned gsi)
> -{
> - struct kvm_irq_ack_notifier *kian;
> - struct hlist_node *n;
> -
> - hlist_for_each_entry(kian, n, &kvm->arch.irq_ack_notifier_list,
> link)
> - if (kian->gsi == gsi)
> - kian->irq_acked(kian);
> -}
> -
> -void kvm_register_irq_ack_notifier(struct kvm *kvm,
> - struct kvm_irq_ack_notifier *kian)
> -{
> - hlist_add_head(&kian->link, &kvm->arch.irq_ack_notifier_list);
> -}
> -
> -void kvm_unregister_irq_ack_notifier(struct kvm *kvm,
> - struct kvm_irq_ack_notifier *kian)
> -{
> - hlist_del(&kian->link);
> -}
>
Where did these go?
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2008-10-02 13:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-29 5:26 [PATCH 4/8]kvm: Split arch/x86/kvm/irq.c to two parts Zhang, Xiantao
2008-10-02 13:04 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48E4C6D0.5080703@redhat.com \
--to=avi@redhat.com \
--cc=kvm-ia64@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=xiantao.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).