From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 0/8] Patchset to enable vt-d support for kvm/ia64. Date: Thu, 02 Oct 2008 18:32:13 +0300 Message-ID: <48E4E97D.4080701@redhat.com> References: <42DFA526FC41B1429CE7279EF83C6BDC01A54162@pdsmsx415.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, kvm-ia64@vger.kernel.org To: "Zhang, Xiantao" Return-path: Received: from mx2.redhat.com ([66.187.237.31]:44157 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754792AbYJBPcR (ORCPT ); Thu, 2 Oct 2008 11:32:17 -0400 In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDC01A54162@pdsmsx415.ccr.corp.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Zhang, Xiantao wrote: > + > +/* This should be called with the kvm->lock mutex held */ > +void kvm_set_irq(struct kvm *kvm, int irq, int level) > +{ > + /* Not possible to detect if the guest uses the PIC or the > + * IOAPIC. So set the bit in both. The guest will ignore > + * writes to the unused one. > + */ > + kvm_ioapic_set_irq(kvm->arch.vioapic, irq, level); > +#ifdef X86 > + kvm_pic_set_irq(pic_irqchip(kvm), irq, level); > +#endif > +} > Will non-x86, non-ia64 archs survive this? -- error compiling committee.c: too many arguments to function