From: Avi Kivity <avi@redhat.com>
To: Amit Shah <amit.shah@redhat.com>, Avi Kivity <avi@redhat.com>,
"Yang, Sheng" <sheng.yang@intel.com>,
"'kvm@vger.kernel.org'" <kvm@vger.kernel.org>,
sheng@linux.intel.com
Subject: Re: [RFC][PATCH 0/2] Fix guest shared interrupt with in-kernel irqchip
Date: Sat, 04 Oct 2008 11:45:02 +0300 [thread overview]
Message-ID: <48E72D0E.4020902@redhat.com> (raw)
In-Reply-To: <20081003103754.GA29951@yukikaze>
Sheng Yang wrote:
> Derived from Avi's suggestion, now every call of kvm_set_irq() should offer
> a irq_source_id, which is allocated by kvm_allocate_irq_sources(). We based
> on irq_source_id to identify irq source and implement logical OR for shared
> level interrupts.
>
> The allocated irq_source_id can be freed by kvm_free_irq_sources().
>
>
> +
> + u32 irq_sources_bitmap;
> + u32 irq_states[KVM_IOAPIC_NUM_PINS];
>
You're using the bit manipulation functions on this, which use unsigned
long parameters. This will generate unaligned accesses, which will
probably annoy ia64 when this code is ported. So it may be better to
wast some space and use unsigned longs here.
Other than that, looks a nice and clean to me.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2008-10-04 8:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-02 8:19 [RFC][PATCH 0/2] Fix guest shared interrupt with in-kernel irqchip Yang, Sheng
2008-10-02 13:27 ` Avi Kivity
2008-10-02 14:06 ` Sheng Yang
2008-10-02 16:45 ` Sheng Yang
2008-10-03 7:36 ` Amit Shah
2008-10-03 10:37 ` Sheng Yang
2008-10-03 10:47 ` Amit Shah
2008-10-04 8:45 ` Avi Kivity [this message]
2008-10-04 8:47 ` Avi Kivity
2008-10-06 6:23 ` Sheng Yang
2008-10-06 6:37 ` Sheng Yang
2008-10-10 12:12 ` Amit Shah
2008-10-08 8:29 ` Sheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48E72D0E.4020902@redhat.com \
--to=avi@redhat.com \
--cc=amit.shah@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=sheng.yang@intel.com \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).