From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/8]kvm: Moving device_assignment logic to kvm_main.c Date: Sun, 05 Oct 2008 11:39:01 +0200 Message-ID: <48E88B35.6030004@redhat.com> References: <42DFA526FC41B1429CE7279EF83C6BDC01A53DF4@pdsmsx415.ccr.corp.intel.com> <200810031239.54863.amit.shah@redhat.com> <42DFA526FC41B1429CE7279EF83C6BDC01A541E8@pdsmsx415.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Amit Shah , kvm@vger.kernel.org, kvm-ia64@vger.kernel.org To: "Zhang, Xiantao" Return-path: Received: from mx2.redhat.com ([66.187.237.31]:47902 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752976AbYJEJjG (ORCPT ); Sun, 5 Oct 2008 05:39:06 -0400 In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDC01A541E8@pdsmsx415.ccr.corp.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Zhang, Xiantao wrote: >>> diff --git a/include/linux/kvm.h b/include/linux/kvm.h >>> index 4269be1..9acf34a 100644 >>> --- a/include/linux/kvm.h >>> +++ b/include/linux/kvm.h >>> @@ -383,7 +383,9 @@ struct kvm_trace_rec { >>> #define KVM_CAP_MP_STATE 14 >>> #define KVM_CAP_COALESCED_MMIO 15 >>> #define KVM_CAP_SYNC_MMU 16 /* Changes to host mmap are reflected >>> in guest */ +#ifdef CONFIG_X86 >>> #define KVM_CAP_DEVICE_ASSIGNMENT 17 >>> +#endif >>> >> I didn't see this changed to also accomodate IA64 in the patchset. >> > > Since linux-ia64 DMAR is not ready in kvm.git, and it should be in > linux-ia64.git. So it should be in kvm.git once Avi merged with > upstream, so I didn't enable it for kvm/ia64 now. You know, S390 has no > pci support, so if we put the code in kvm_mainc, we should use the macro > to exclude other arch which doesn't need device assignments. If DMAR is > ready for kvm.git, I will change this macro as following: > #if defined(CONFIG_X86) || defined(CONFIG_IA64) > #define KVM_CAP_DEVICE_ASSIGNMENT 17 > #endif > What does this mean? Does the patchset compile on top of kvm.git or not? -- error compiling committee.c: too many arguments to function