From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 14/17] qemu: x86: Debug register emulation Date: Tue, 07 Oct 2008 14:15:13 +0200 Message-ID: <48EB52D1.3020204@redhat.com> References: <20081006091415.095241851@mchn012c.ww002.siemens.net> <20081006091417.670837853@mchn012c.ww002.siemens.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Jan Kiszka Return-path: Received: from mx2.redhat.com ([66.187.237.31]:37035 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753035AbYJGMPR (ORCPT ); Tue, 7 Oct 2008 08:15:17 -0400 In-Reply-To: <20081006091417.670837853@mchn012c.ww002.siemens.net> Sender: kvm-owner@vger.kernel.org List-ID: Jan Kiszka wrote: > Built on top of previously enhanced breakpoint/watchpoint support, this > patch adds full debug register emulation for the x86 architecture. > > Many corner cases were considered, and the result was successfully > tested inside a Linux guest with gdb, but I won't be surprised if one > or two scenarios still behave differently in reality. > > + > +static inline int hw_breakpoint_len(unsigned long dr7, int index) > +{ > + return ((dr7 >> (DR7_LEN_SHIFT + (index * 2))) & 3) + 1; > +} > + > A len encoding of 2 means an 8-byte breakpoint. -- error compiling committee.c: too many arguments to function