Re: [PATCH 16/17] kvm-userspace: Provide compat wrapper for set_debugreg

[Avi Kivity <avi@redhat.com>]

Jan Kiszka wrote:
> Older set_debugreg macros did not allow to pass the register number as
> constant (without additional typcasting). Catch this as the latest kvm
> debug changes make use of this property.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  kernel/external-module-compat-comm.h |   10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> Index: b/kernel/external-module-compat-comm.h
> ===================================================================
> --- a/kernel/external-module-compat-comm.h
> +++ b/kernel/external-module-compat-comm.h
> @@ -539,6 +539,16 @@ struct pci_dev *pci_get_bus_and_slot(uns
>  
>  #endif
>  
> +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,25) && defined(__x86_64__)
> +
> +#undef set_debugreg
> +#define set_debugreg(value, register) \
> +	__asm__("movq %0,%%db" #register \
> +		: /* no output */ \
> +		:"r" ((unsigned long)value))
> +
> +#endif
> +
>  #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,21)
>  
>   

Should be in the x86 specific file (kernel/x86/external-module.h)

-- 
error compiling committee.c: too many arguments to function