From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH 4/4] KVM: x86: Enable MSI for assigned device
Date: Tue, 07 Oct 2008 15:42:41 +0200
Message-ID: <48EB6751.9080901@redhat.com>
References: <> <48E89688.1010500@redhat.com> <200810061136.08909.sheng.yang@intel.com> <200810071359.58975.sheng@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, "Han, Weidong" <weidong.han@intel.com>,
	"Kay, Allen M" <allen.m.kay@intel.com>
To: Sheng Yang <sheng@linux.intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:47804 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753378AbYJGNnU (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 7 Oct 2008 09:43:20 -0400
In-Reply-To: <200810071359.58975.sheng@linux.intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Sheng Yang wrote:
> Seems we needn't tell userspace if MSI can be enabled. It's determined mostly 
> by the device, and pci_enable_msi() checked that. 
>
> So I think QEmu can expose MSI capability if the device got it. If it's fail 
> to be enabled, just fall back to IRQ and return error to QEmu is enough, of 
> course, QEmu should set MSI enable bit after kernel space done.
>   

Do we need to add the additional condition, "and if the host kernel 
supports it"?

-- 
error compiling committee.c: too many arguments to function