From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 0/6] MTRR/PAT support for EPT (v3) Date: Thu, 09 Oct 2008 11:03:24 +0200 Message-ID: <48EDC8DC.5050006@redhat.com> References: <1223539317-32379-1-git-send-email-sheng@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Sheng Yang Return-path: Received: from mx2.redhat.com ([66.187.237.31]:42411 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753672AbYJIJDa (ORCPT ); Thu, 9 Oct 2008 05:03:30 -0400 In-Reply-To: <1223539317-32379-1-git-send-email-sheng@linux.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Sheng Yang wrote: > Hi, Avi > > Here is the latest update of MTRR/PAT support. > > Change from v2: > Discard the using of MSR bitmap, add MSR_IA32_CR_PAT to save/restore, as well > as rebase on latest upstream. > > Applied all; my comments about shadow can be addressed later. There is also the danger of the guest setting the wrong MTRR type for RAM, thus introducing incompatible memory types (between qemu and the guest). If this is a problem, we should ignore the guest's mtrr (and pat) for RAM and use write-back instead. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.