From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] x86 emulator: Add Src2 decode set Date: Thu, 09 Oct 2008 11:06:50 +0200 Message-ID: <48EDC9AA.5010407@redhat.com> References: <20081008145245.78c7084d@frecb000711> <48ECC028.5070807@redhat.com> <20081009095253.66737bf1@frecb000711> <48EDBCCD.4010705@redhat.com> <20081009105744.40478c77@frecb000711> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: kvm To: Guillaume Thouvenin Return-path: Received: from mx2.redhat.com ([66.187.237.31]:36158 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758513AbYJIJH0 (ORCPT ); Thu, 9 Oct 2008 05:07:26 -0400 In-Reply-To: <20081009105744.40478c77@frecb000711> Sender: kvm-owner@vger.kernel.org List-ID: Guillaume Thouvenin wrote: > I will add Src2One but I don't understand exactly what you mean by > switching shift operators to Src2 later. I also applied other remarks, > thanks for your help. The patch follows. > The regular shift instructions (shl, rcl, etc) come in three varieties: shift by 1, shift by imm8, and shift by CL. Right now they use SrcImmByte and decode the implied '1' and CL by hand. If we change them to use Src2, they can reuse the Src2CL and Src2One support that you are adding now. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.