From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] [RESEND] VT-d: Support multiple device assignment to one guest Date: Fri, 10 Oct 2008 08:40:12 +0200 Message-ID: <48EEF8CC.5000309@redhat.com> References: <48EDFE00.5050103@redhat.com> <0122C7C995D32147B66BF4F440D3016301CB08EF@pdsmsx415.ccr.corp.intel.com> <0122C7C995D32147B66BF4F440D3016301D55E1A@pdsmsx415.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Joerg Roedel , kvm@vger.kernel.org, Amit Shah , "Kay, Allen M" , "Yang, Sheng" , benami@il.ibm.com, muli@il.ibm.com, "Woodhouse, David" , "Barnes, Jesse" To: "Han, Weidong" Return-path: Received: from mx2.redhat.com ([66.187.237.31]:40320 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752495AbYJJGlB (ORCPT ); Fri, 10 Oct 2008 02:41:01 -0400 In-Reply-To: <0122C7C995D32147B66BF4F440D3016301D55E1A@pdsmsx415.ccr.corp.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Han, Weidong wrote: > It's hard to move kvm_vtd_domain inside current iommu API. It's kvm > specific. It's not elegant to include kvm_vtd_domain stuffs in native > VT-d code. It's cleaner than adding knowledge of how the iommu works to kvm. > I think leave it in kvm side is more clean at this point. > Moveover it's very simple. I read Joerg's iommu API foils just now, I > think it's good. Native AMD iommu code will be in 2.6.28, it's a > suitable to implement a generic iommu API based both on Intel and AMD > iommu for kvm after 2.6.28. What's your opinion? > 2.6.27 is out, so anything we do will be for 2.6.29. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.