public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: "Zhang, Xiantao" <xiantao.zhang@intel.com>
Cc: kvm-ia64@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: kvm/ia64: Fix halt emulation logic.
Date: Thu, 16 Oct 2008 10:53:22 +0200	[thread overview]
Message-ID: <48F70102.2020909@redhat.com> (raw)
In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDC01B47EA5@pdsmsx415.ccr.corp.intel.com>

Zhang, Xiantao wrote:
> Hi, Avi 
> 	This is the key fix for 2.6.28 merge. Without this patch, guest
> may hang once configured with more than 2 vcpus, it is because x86 side
> changed the halt handling's common logic, but it misses to change ia64
> side. 
>   

> @@ -398,8 +400,11 @@ static int handle_global_purge(struct kvm_vcpu
> *vcpu, struct kvm_run *kvm_run)
>  
>  		if (kvm->vcpus[i]->cpu != -1) {
>  			call_data.vcpu = kvm->vcpus[i];
> -			smp_call_function_single(kvm->vcpus[i]->cpu,
> +			if (kvm->vcpus[i]->cpu != smp_processor_id())
> +
> smp_call_function_single(kvm->vcpus[i]->cpu,
>  					vcpu_global_purge, &call_data,
> 1);
> +			else
> +				vcpu_global_purge(&call_data);
>   

smp_call_function_single() will call the function on the current cpu if 
instructed, so this change is unneeded.

-- 
error compiling committee.c: too many arguments to function


  reply	other threads:[~2008-10-16  8:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-15 13:47 kvm/ia64: Fix halt emulation logic Zhang, Xiantao
2008-10-16  8:53 ` Avi Kivity [this message]
2008-10-16  8:57   ` Zhang, Xiantao
2008-10-16  9:01     ` Avi Kivity
2008-10-16  9:19       ` Zhang, Xiantao
2008-10-16  9:43         ` Avi Kivity
2008-10-18 15:27 ` Marcelo Tosatti
2008-11-03  4:36   ` Zhang, Xiantao
  -- strict thread matches above, loose matches on Subject: below --
2008-10-15 13:52 Zhang, Xiantao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48F70102.2020909@redhat.com \
    --to=avi@redhat.com \
    --cc=kvm-ia64@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=xiantao.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox