From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 04/10] Implement GIF, clgi and stgi v4 Date: Sun, 19 Oct 2008 12:04:32 +0200 Message-ID: <48FB0630.4080503@redhat.com> References: <1224099093-10985-1-git-send-email-agraf@suse.de> <1224099093-10985-2-git-send-email-agraf@suse.de> <1224099093-10985-3-git-send-email-agraf@suse.de> <1224099093-10985-4-git-send-email-agraf@suse.de> <1224099093-10985-5-git-send-email-agraf@suse.de> <48FB020B.302@redhat.com> <69FC60AA-E2F0-489E-B992-C0ECBF792E85@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, joro@8bytes.org, anthony@codemonkey.ws To: Alexander Graf Return-path: Received: from mx2.redhat.com ([66.187.237.31]:53049 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750698AbYJSKEk (ORCPT ); Sun, 19 Oct 2008 06:04:40 -0400 In-Reply-To: <69FC60AA-E2F0-489E-B992-C0ECBF792E85@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: Alexander Graf wrote: >>> }; >>> +#define HF_GIF_MASK (1 << 0) >>> + >> >> Why not use bool for gif? It will improve code readability. > > This way the code is closer to what qemu cpu emulation is doing > (probably no good reason). Also it allows for more flags to be added > later on. I originally had a VMLOAD/VMRUN/VMSAVE merging hack, that > would set the hflag - until I realized that it's not SMP safe. > Well, bool is also extensible (add more bools...). > Nevertheless, I thought it might be better to have something that's > easily extensible. If you think otherwise, I'd change it, but I like > the hflags idea in general. It's a matter of personal preference; I guess it would be silly for me to insist on such a small point given the massive amount of work that has gone into this. So I'll leave it up to you. -- error compiling committee.c: too many arguments to function