From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] x86 emulator: Add a Src2 decode set and SrcOne operand type Date: Wed, 22 Oct 2008 12:29:48 +0200 Message-ID: <48FF009C.5030705@redhat.com> References: <20081008145245.78c7084d@frecb000711> <48ECC028.5070807@redhat.com> <20081009095253.66737bf1@frecb000711> <48EDBCCD.4010705@redhat.com> <20081009132359.0602a8d2@frecb000711> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm To: Guillaume Thouvenin Return-path: Received: from mx2.redhat.com ([66.187.237.31]:35632 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752000AbYJVKaY (ORCPT ); Wed, 22 Oct 2008 06:30:24 -0400 In-Reply-To: <20081009132359.0602a8d2@frecb000711> Sender: kvm-owner@vger.kernel.org List-ID: Guillaume Thouvenin wrote: > Instruction like shld has three operands, so we need to add a Src2 > decode set. We start with Src2None, Src2CL, and Src2Imm8 to support > shld and we will expand it later. Operand type of Src2 are placed at > the end of the set to avoid renumbering. For Src2CL we mask to a single > byte and set the operand length. > > This patch also added SrcOne operand type when we need to decode an > implied '1' like with regular shift instruction. > > Looks fine; I will apply when shld/shrd are ready. > If needed I can split this patch into two patches, one for Src2 decode > set and another one for SrcOne. > Maybe even three: extend the opcode descriptor to 32 bits, add SrcOne, add Src2*. -- error compiling committee.c: too many arguments to function