From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH 0/8] Support for S3 ACPI state (suspend to memory) Date: Thu, 23 Oct 2008 11:12:59 -0500 Message-ID: <4900A28B.6050509@codemonkey.ws> References: <20081023140459.10303.39562.stgit@gleb-debian.qumranet.com.qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from rn-out-0910.google.com ([64.233.170.190]:2325 "EHLO rn-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753842AbYJWQNF (ORCPT ); Thu, 23 Oct 2008 12:13:05 -0400 Received: by rn-out-0910.google.com with SMTP id k40so221155rnd.17 for ; Thu, 23 Oct 2008 09:13:02 -0700 (PDT) In-Reply-To: <20081023140459.10303.39562.stgit@gleb-debian.qumranet.com.qumranet.com> Sender: kvm-owner@vger.kernel.org List-ID: Hi Gleb, Gleb Natapov wrote: > Hello, > > This patch series adds S3 (suspend to RAM) ACPI state. Most changes > are in the BIOS code and concern themselves with preventing BIOS from > using memory available to OS. > I thought you initially sent this to qemu-devel. Any reason not to push this through QEMU instead of in KVM? Regards, Anthony Liguori > --- > > Gleb Natapov (8): > Don't power down vga card on entering S3 state. > Add DPMS support to cirrus vga bios. > Don't use unreserved memory in BIOS. > Execute rombios32 code from rom address 0xe0000. > Disable init of SMM. > Add S3 state to DSDT. Handle resume event in the BIOS. > Handle suspend in qemu. > Move PIC initialization out of line to save space in post code area. > > > bios/Makefile | 1 > bios/acpi-dsdt.dsl | 49 +++++++++++++++++++---- > bios/rombios.c | 106 ++++++++++++++++++++++++++++++------------------- > bios/rombios.h | 4 +- > bios/rombios32.c | 78 +++++++++++++++++++++++++++++++++--- > bios/rombios32.ld | 8 +--- > bios/rombios32start.S | 9 ++++ > qemu/hw/acpi.c | 10 +++++ > qemu/hw/pc.c | 8 ++++ > qemu/hw/pc.h | 1 > qemu/qemu-kvm.c | 2 - > qemu/qemu-kvm.h | 1 > vgabios/clext.c | 36 ++++++++++++++++- > 13 files changed, 247 insertions(+), 66 deletions(-) > > >