From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 0/8] Support for S3 ACPI state (suspend to memory) Date: Thu, 23 Oct 2008 21:51:22 +0200 Message-ID: <4900D5BA.3050308@redhat.com> References: <20081023140459.10303.39562.stgit@gleb-debian.qumranet.com.qumranet.com> <4900A28B.6050509@codemonkey.ws> <4900A879.3030505@redhat.com> <4900BFBB.6070300@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Gleb Natapov , kvm@vger.kernel.org To: Anthony Liguori Return-path: Received: from mx2.redhat.com ([66.187.237.31]:35884 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752729AbYJWTvS (ORCPT ); Thu, 23 Oct 2008 15:51:18 -0400 In-Reply-To: <4900BFBB.6070300@codemonkey.ws> Sender: kvm-owner@vger.kernel.org List-ID: Anthony Liguori wrote: >> >> Since it requires bios changes, it is basically unpushable to qemu. > > Why? As long as Gleb is willing to push those changes to Bochs, I'll > stick them in the bios.diff for now. The hard part is the dsdt > changes but if the build is changed to run the dsdt through cpp first, > we can just #ifdef BX_QEMU the qemu specific stuff. > I forgot bios.diff. So yes, it's mergable into qemu. >> It may also depend on existing kvm bios and acpi changes. > > How much dependency is there here? > I don't know; and that can be pulled as well (if anything needs pulling). >> >> If it is possible to do this via qemu, of course I much prefer that >> route. > > I looked through the patches. They're quite reasonable so I'd like to > push them into QEMU if it's possible. That's the best way IMO as well. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.