From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH 3/8] Add S3 state to DSDT. Handle resume event in the
 BIOS.
Date: Sun, 26 Oct 2008 16:58:52 +0200
Message-ID: <490485AC.1010905@redhat.com>
References: <20081023140459.10303.39562.stgit@gleb-debian.qumranet.com.qumranet.com> <20081023140515.10303.38088.stgit@gleb-debian.qumranet.com.qumranet.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org
To: Gleb Natapov <gleb@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:33281 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752862AbYJZO66 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 26 Oct 2008 10:58:58 -0400
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id m9QEwv6U032648
	for <kvm@vger.kernel.org>; Sun, 26 Oct 2008 10:58:57 -0400
In-Reply-To: <20081023140515.10303.38088.stgit@gleb-debian.qumranet.com.qumranet.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Gleb Natapov wrote:
> Signed-off-by: Gleb Natapov <gleb@redhat.com>
> ---
>
>  bios/acpi-dsdt.dsl |   33 ++++++++++++++++++-----
>  bios/rombios.c     |   35 +++++++++++++++++++++++++
>  bios/rombios32.c   |   74 ++++++++++++++++++++++++++++++++++++++++++++++++----
>  3 files changed, 130 insertions(+), 12 deletions(-)
>
> diff --git a/bios/acpi-dsdt.dsl b/bios/acpi-dsdt.dsl
> index 577b3fe..02f53a1 100755
> --- a/bios/acpi-dsdt.dsl
> +++ b/bios/acpi-dsdt.dsl
> @@ -65,6 +65,32 @@ DefinitionBlock (
>  	gen_processor(14, E)
>      }
>  
> +    /*
> +     * S3 (suspend-to-ram), S4 (suspend-to-disc) and S5 (power-off) type codes:
> +     * must match piix4 emulation.
> +     */
> +    Name (\_S3, Package (0x04)
> +    {
> +        0x01,  /* PM1a_CNT.SLP_TYP */
> +        0x01,  /* PM1b_CNT.SLP_TYP */
> +        Zero,  /* reserved */
> +        Zero   /* reserved */
> +    })
> +    Name (\_S4, Package (0x04)
> +    {
> +        Zero,  /* PM1a_CNT.SLP_TYP */
> +        Zero,  /* PM1b_CNT.SLP_TYP */
> +        Zero,  /* reserved */
> +        Zero   /* reserved */
> +    })
> +    Name (\_S5, Package (0x04)
> +    {
> +        Zero,  /* PM1a_CNT.SLP_TYP */
> +        Zero,  /* PM1b_CNT.SLP_TYP */
> +        Zero,  /* reserved */
> +        Zero   /* reserved */
> +    })
> +
>      Scope (\)
>      {
>          /* Debug Output */
> @@ -626,13 +652,6 @@ DefinitionBlock (
>          }
>      }
>  
> -    /* S5 = power off state */
> -    Name (_S5, Package (4) {
> -        0x00, // PM1a_CNT.SLP_TYP
> -        0x00, // PM2a_CNT.SLP_TYP
> -        0x00, // reserved
> -        0x00, // reserved
> -    })
>      Scope (\_GPE)
>      {
>   
Any reason for the code movement?


-- 
error compiling committee.c: too many arguments to function