From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH] x86 emulator: move skip_emulated_instruction()
Date: Tue, 28 Oct 2008 12:49:39 +0200
Message-ID: <4906EE43.2010601@redhat.com>
References: <20081028105130.372783d8@frecb000711>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm <kvm@vger.kernel.org>
To: Guillaume Thouvenin <guillaume.thouvenin@ext.bull.net>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:46558 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751344AbYJ1OXW (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 28 Oct 2008 10:23:22 -0400
In-Reply-To: <20081028105130.372783d8@frecb000711>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Guillaume Thouvenin wrote:
>  If we call the emulator we shouldn't call skip_emulated_instruction()
> in the first place, since the emulator already computes the next rip
> for us. Thus we move ->skip_emulated_instruction() out of
> kvm_emulate_pio() and into handle_io() (and the svm equivalent). We
> also replaced "return 0" by "break" in the "do_io:" case because now
> the shadow register state needs to be committed. Otherwise eip will never
> be updated.
>   

Applied, thanks.

-- 
error compiling committee.c: too many arguments to function