From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 0/2] kvm: disable virtualization on kdump Date: Wed, 29 Oct 2008 11:41:36 +0200 Message-ID: <49082FD0.3040009@redhat.com> References: <4904676F.3020706@redhat.com> <490487C1.1010707@redhat.com> <20081026213927.GF23893@blackpad> <49058645.9010005@redhat.com> <20081027122808.GH23893@blackpad> <4905C9ED.807@redhat.com> <20081028194530.GK23893@blackpad> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Andrew Morton , Eduardo Habkost , kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Haren Myneni , Simon Horman , Vivek Goyal To: "Eric W. Biederman" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kexec-bounces-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Errors-To: kexec-bounces+glkk-kexec=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: kvm.vger.kernel.org Eric W. Biederman wrote: >> I think I will get flamed if I try to pull to the core a bunch of code >> that always lived in the KVM module. 8) >> > > Why is KVM modular anyway? That seems like some pretty core cpu functionality... > Many reasons. Developers like the ability to rmmod and modprobe during development. Distros like to keep their non-modular core small. There is an external module distribution that allows users to graft a new kvm on an old kernel, which our testers and bleeding edge users like. Because it's there. There's always CONFIG_KVM=y if you don't want it. > Depending. It doesn't sound like svm has the problem where init doesn't > work so svm really doesn't need to do this. > svm can writeback into memory at odd times if we don't do this, and the cost is small - clear a bit in EFER. There's no reason to be lazy. -- error compiling committee.c: too many arguments to function