From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: KVM: MMU: increase per-vcpu rmap cache alloc size Date: Wed, 29 Oct 2008 11:42:31 +0200 Message-ID: <49083007.3090903@redhat.com> References: <20081028201658.GA15156@dmt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Marcelo Tosatti Return-path: Received: from mx2.redhat.com ([66.187.237.31]:45690 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753118AbYJ2Jme (ORCPT ); Wed, 29 Oct 2008 05:42:34 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id m9T9gY2J021352 for ; Wed, 29 Oct 2008 05:42:34 -0400 In-Reply-To: <20081028201658.GA15156@dmt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: Marcelo Tosatti wrote: > The page fault path can use two rmap_desc structures, if: > > - walk_addr's dirty pte update allocates one rmap_desc. > - mmu_lock is dropped, sptes are zapped resulting in rmap_desc being > freed. > - fetch->mmu_set_spte allocates another rmap_desc. > > Increase to 4 for safety. > Applied and queued for 2.6.28, thanks. -- error compiling committee.c: too many arguments to function