From: Anthony Liguori <anthony@codemonkey.ws>
To: Jes Sorensen <jes@sgi.com>
Cc: Hollis Blanchard <hollisb@us.ibm.com>,
Glauber Costa <glommer@gmail.com>,
kvm@vger.kernel.org, kvm-ia64@vger.kernel.org
Subject: Re: [patch] v4 - fold struct vcpu_info into CPUState
Date: Wed, 29 Oct 2008 08:01:01 -0500 [thread overview]
Message-ID: <49085E8D.4050305@codemonkey.ws> (raw)
In-Reply-To: <49073D0C.6030706@sgi.com>
Jes Sorensen wrote:
> Hi,
>
> Here's an updated version of the patch. It should fix the problems
> Hollis ran into, and also compile on x86_64 again :-)
>
> I managed to get rid of all the runtime use of qemu_kvm_cpu_env(),
> except for the hotplug code. But I think it's reasonable to do the
> walk of the linked list in that case. However, the more I have looked
> at this, the more obvious to me it becomes that it is right<tm> to
> expose struct CPUState to libkvm, and avoid passing around int vcpu.
>
> Comments and test reports very welcome!
FWIW, vcpu_info seems to have nothing to do with KVM. It's entirely
build around the IO thread. The IO thread really isn't KVM specific.
I would just stick these fields in CPU_COMMON unconditionally if you're
going to move them at all.
Regards,
Anthony Liguori
> Cheers,
> Jes
>
next prev parent reply other threads:[~2008-10-29 13:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-29 15:24 [patch] fold struct vcpu_info into CPUState Jes Sorensen
2008-10-05 10:02 ` Avi Kivity
2008-10-05 20:48 ` Glauber Costa
2008-10-13 22:24 ` Glauber Costa
2008-10-17 15:28 ` Jes Sorensen
2008-10-17 21:27 ` Glauber Costa
2008-10-24 15:57 ` Jes Sorensen
2008-10-24 19:10 ` Hollis Blanchard
2008-10-27 9:48 ` Jes Sorensen
2008-10-27 16:02 ` Hollis Blanchard
2008-10-28 16:25 ` [patch] v4 - " Jes Sorensen
2008-10-29 13:01 ` Anthony Liguori [this message]
2008-10-29 13:04 ` Jes Sorensen
2008-10-29 13:09 ` Anthony Liguori
2008-10-27 16:06 ` [patch] " Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49085E8D.4050305@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=glommer@gmail.com \
--cc=hollisb@us.ibm.com \
--cc=jes@sgi.com \
--cc=kvm-ia64@vger.kernel.org \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).