Re: [PATCH 3/3] Add KVM support to QEMU

Anthony Liguori
2008-10-29T19:01:55Z

Glauber Costa wrote:
> resending, now with less quoted text:
>

Yeah, I was intending to scold you about that ;-)

>> diff --git a/kvm-all.c b/kvm-all.c
>> new file mode 100644
>> index 0000000..4379071
>> --- /dev/null
>> +++ b/kvm-all.c
>> @@ -0,0 +1,377 @@
>> +/*
>> + * QEMU KVM support
>> + *
>> + * Copyright IBM, Corp. 2008
>> + *
>> + * Authors:
>> + * Anthony Liguori <aliguori@us.ibm.com>
>> + *
>> + * This work is licensed under the terms of the GNU GPL, version 2. See
>> + * the COPYING file in the top-level directory.
>> + *
>> + */
>> +
>> +#include <sys/types.h>
>> +#include <sys/ioctl.h>
>> +#include <sys/mman.h>
>> +
>> +#include <linux/kvm.h>
>> +
>> +#include "qemu-common.h"
>> +#include "sysemu.h"
>> +#include "kvm.h"
>> +
>> +//#define DEBUG_KVM
>> +
>> +#ifdef DEBUG_KVM
>> +#define dprintf(fmt, ...) \
>> + do { fprintf(stderr, fmt, ## __VA_ARGS__); } while (0)
>> +#else
>> +#define dprintf(fmt, ...) \
>> + do { } while (0)
>> +#endif
>> +
>> +typedef struct kvm_userspace_memory_region KVMSlot;
>>
>
> Actually, I don't think it is a good idea.
> We may want to keep internal-only data tied to the slot, such the slot's
> dirty bitmap if we do per-slot dirty tracking.
>
> Of course there may be other ways to do it, but this is the cleaner
> and more adequate since we're going through a fresh start.
>

For now, I think it's fine. Switching to making it a proper structure
is certainly a good idea when we get more stuff per slot.

Regards,

Anthony Liguori