From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 9/9] Allow setting the SVME bit v5 Date: Wed, 29 Oct 2008 16:17:13 +0200 Message-ID: <49087069.8040903@redhat.com> References: <1224522290-11740-1-git-send-email-agraf@suse.de> <1224522290-11740-2-git-send-email-agraf@suse.de> <1224522290-11740-3-git-send-email-agraf@suse.de> <1224522290-11740-4-git-send-email-agraf@suse.de> <1224522290-11740-5-git-send-email-agraf@suse.de> <1224522290-11740-6-git-send-email-agraf@suse.de> <1224522290-11740-7-git-send-email-agraf@suse.de> <1224522290-11740-8-git-send-email-agraf@suse.de> <1224522290-11740-9-git-send-email-agraf@suse.de> <1224522290-11740-10-git-send-email-agraf@suse.de> <20081029135832.GE11682@8bytes.org> <063522FE-5E35-44A0-AE99-B594CEC61363@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Joerg Roedel , kvm@vger.kernel.org, anthony@codemonkey.ws To: Alexander Graf Return-path: Received: from mx2.redhat.com ([66.187.237.31]:35208 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753007AbYJ2ORV (ORCPT ); Wed, 29 Oct 2008 10:17:21 -0400 In-Reply-To: <063522FE-5E35-44A0-AE99-B594CEC61363@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: Alexander Graf wrote: > I don't believe we need a userspace interface for now. The userspace > part does not need to know what capabilities the virtual CPU has - > that's what the CPUID masking in the kvm code is for IMHO. It's the other way round. The kernel exposes which features are available, and userspace decides what to present to the guest. Kernel masking means userspace doesn't really know what the guest sees. The existing masking in the kernel is due to bugs. -- error compiling committee.c: too many arguments to function