From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <aliguori@us.ibm.com>
Subject: Re: [PATCH 3/3] Add KVM support to QEMU
Date: Wed, 29 Oct 2008 14:01:40 -0500
Message-ID: <4908B314.1030703@us.ibm.com>
References: <1225224814-9875-1-git-send-email-aliguori@us.ibm.com> <1225224814-9875-2-git-send-email-aliguori@us.ibm.com> <1225224814-9875-3-git-send-email-aliguori@us.ibm.com> <20081029174122.GE11532@poweredge.glommer>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>,
	kvm-devel <kvm@vger.kernel.org>
To: Glauber Costa <glommer@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from e36.co.us.ibm.com ([32.97.110.154]:52126 "EHLO
	e36.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751119AbYJ2TBz (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 29 Oct 2008 15:01:55 -0400
Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227])
	by e36.co.us.ibm.com (8.13.8/8.13.8) with ESMTP id m9TJ1sRh019237
	for <kvm@vger.kernel.org>; Wed, 29 Oct 2008 15:01:55 -0400
Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169])
	by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id m9TJ1sGK046846
	for <kvm@vger.kernel.org>; Wed, 29 Oct 2008 13:01:54 -0600
Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1])
	by d03av03.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m9TJ1qbV010124
	for <kvm@vger.kernel.org>; Wed, 29 Oct 2008 13:01:53 -0600
In-Reply-To: <20081029174122.GE11532@poweredge.glommer>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Glauber Costa wrote:
> resending, now with less quoted text:
>   

Yeah, I was intending to scold you about that ;-)

>> diff --git a/kvm-all.c b/kvm-all.c
>> new file mode 100644
>> index 0000000..4379071
>> --- /dev/null
>> +++ b/kvm-all.c
>> @@ -0,0 +1,377 @@
>> +/*
>> + * QEMU KVM support
>> + *
>> + * Copyright IBM, Corp. 2008
>> + *
>> + * Authors:
>> + *  Anthony Liguori   <aliguori@us.ibm.com>
>> + *
>> + * This work is licensed under the terms of the GNU GPL, version 2.  See
>> + * the COPYING file in the top-level directory.
>> + *
>> + */
>> +
>> +#include <sys/types.h>
>> +#include <sys/ioctl.h>
>> +#include <sys/mman.h>
>> +
>> +#include <linux/kvm.h>
>> +
>> +#include "qemu-common.h"
>> +#include "sysemu.h"
>> +#include "kvm.h"
>> +
>> +//#define DEBUG_KVM
>> +
>> +#ifdef DEBUG_KVM
>> +#define dprintf(fmt, ...) \
>> +    do { fprintf(stderr, fmt, ## __VA_ARGS__); } while (0)
>> +#else
>> +#define dprintf(fmt, ...) \
>> +    do { } while (0)
>> +#endif
>> +
>> +typedef struct kvm_userspace_memory_region KVMSlot;
>>     
>
> Actually, I don't think it is a good idea.
> We may want to keep internal-only data tied to the slot, such the slot's
> dirty bitmap if we do per-slot dirty tracking.
>
> Of course there may be other ways to do it, but this is the cleaner
> and more adequate since we're going through a fresh start.
>   

For now, I think it's fine.  Switching to making it a proper structure 
is certainly a good idea when we get more stuff per slot.

Regards,

Anthony Liguori