From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [00/03][PATCH] kvm-ia64 updates for linux-2.6.28-rc2
Date: Thu, 30 Oct 2008 11:36:21 +0200
Message-ID: <49098015.4000901@redhat.com>
References: <706158FABBBA044BAD4FE898A02E4BC2140C7FE4@pdsmsx503.ccr.corp.intel.com> <490872D0.40006@redhat.com> <706158FABBBA044BAD4FE898A02E4BC2140C8363@pdsmsx503.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "kvm-ia64@vger.kernel.org" <kvm-ia64@vger.kernel.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
To: "Zhang, Xiantao" <xiantao.zhang@intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:52227 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752136AbYJ3JgN (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 30 Oct 2008 05:36:13 -0400
In-Reply-To: <706158FABBBA044BAD4FE898A02E4BC2140C8363@pdsmsx503.ccr.corp.intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Zhang, Xiantao wrote:
> 	It is a potential issue. If the vcpu goes to halt with the lock taken, other vcpus wants to take write lock, they have to wait until the all halted vcpus are waken up, so  it may impact performance.  :)

What is the impact?  Taking slots_lock for write is very rare.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.