From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH 4/9] Implement hsave v5 Date: Thu, 30 Oct 2008 14:05:30 -0500 Message-ID: <490A057A.20305@codemonkey.ws> References: <1224522290-11740-1-git-send-email-agraf@suse.de> <1224522290-11740-2-git-send-email-agraf@suse.de> <1224522290-11740-3-git-send-email-agraf@suse.de> <1224522290-11740-4-git-send-email-agraf@suse.de> <1224522290-11740-5-git-send-email-agraf@suse.de> <4909F71E.2030306@codemonkey.ws> <4C0FB979-99A3-49AD-9AE5-DA2A066DC2E1@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, joro@8bytes.org, avi@redhat.com To: Alexander Graf Return-path: Received: from yw-out-2324.google.com ([74.125.46.28]:7545 "EHLO yw-out-2324.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755482AbYJ3TFf (ORCPT ); Thu, 30 Oct 2008 15:05:35 -0400 Received: by yw-out-2324.google.com with SMTP id 9so327022ywe.1 for ; Thu, 30 Oct 2008 12:05:34 -0700 (PDT) In-Reply-To: <4C0FB979-99A3-49AD-9AE5-DA2A066DC2E1@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: Alexander Graf wrote: > > On 30.10.2008, at 19:04, Anthony Liguori wrote: > > >>> >>> kmem_cache_free(kvm_vcpu_cache, svm); >>> } >>> @@ -1376,6 +1383,9 @@ static int svm_get_msr(struct kvm_vcpu *vcpu, >>> unsigned ecx, u64 *data) >>> case MSR_IA32_LASTINTTOIP: >>> *data = svm->vmcb->save.last_excp_to; >>> break; >>> + case MSR_VM_HSAVE_PA: >>> + *data = 0; >>> + break; >>> >> >> I'm confused as to why you aren't allowing userspace to set/get this >> MSR? Wouldn't it be needed for save/restore? > > I don't see any benefit from actually exporting that MSR atm. KVM does > never read it and it'd just add additional overhead on every userspace > transition, as it'd need to be synced every time. Save and restore? Regards, Anthony Liguori > Alex >