From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH 3/9] Implement GIF, clgi and stgi v5 Date: Thu, 30 Oct 2008 14:08:23 -0500 Message-ID: <490A0627.7020206@codemonkey.ws> References: <1224522290-11740-1-git-send-email-agraf@suse.de> <1224522290-11740-2-git-send-email-agraf@suse.de> <1224522290-11740-3-git-send-email-agraf@suse.de> <1224522290-11740-4-git-send-email-agraf@suse.de> <4909F6B1.4060503@codemonkey.ws> <4909F87A.1090908@redhat.com> <5A4061D1-03CF-42F8-946D-ABF56454FC84@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Avi Kivity , kvm@vger.kernel.org, joro@8bytes.org To: Alexander Graf Return-path: Received: from yx-out-2324.google.com ([74.125.44.29]:14863 "EHLO yx-out-2324.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755607AbYJ3TI2 (ORCPT ); Thu, 30 Oct 2008 15:08:28 -0400 Received: by yx-out-2324.google.com with SMTP id 8so326842yxm.1 for ; Thu, 30 Oct 2008 12:08:26 -0700 (PDT) In-Reply-To: <5A4061D1-03CF-42F8-946D-ABF56454FC84@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: Alexander Graf wrote: > > On 30.10.2008, at 19:10, Avi Kivity wrote: >>> GIF somehow needs exposure to userspace too, right? Otherwise, when >>> using -no-kernel-apic, userspace may try to inject an interrupt when >>> the guest cannot handle it, right? >> >> Hmm, right, it needs to close the interrupt window. > > Yes, it's broken with -no-kernel-apic, since the userspace doesn't > know the window is closed. Any good suggestions here? Joerg and me > decided to just ignore the non-kernel-apic case, but if it's important > we might want to sync the hflags with userspace, so we can export the > GIF. Maybe abusing kvm_run->if_flag? Current, userspace treats if_flag as a boolean. If you stored GIF and eflags.IF in there, I believe old userspaces would just work. Regards, Anthony Liguori > Alex >