From: Anthony Liguori <anthony@codemonkey.ws>
To: Avi Kivity <avi@redhat.com>
Cc: Alexander Graf <agraf@suse.de>, kvm@vger.kernel.org, joro@8bytes.org
Subject: Re: [PATCH 3/9] Implement GIF, clgi and stgi v5
Date: Thu, 30 Oct 2008 14:11:24 -0500 [thread overview]
Message-ID: <490A06DC.5030107@codemonkey.ws> (raw)
In-Reply-To: <4909F87A.1090908@redhat.com>
Avi Kivity wrote:
> Anthony Liguori wrote:
>>>
>>> +static int stgi_interception(struct vcpu_svm *svm, struct kvm_run
>>> *kvm_run)
>>> +{
>>
>> It feels a little strange to see this here instead of an
>> implementation of stgi/clgi in x86_emulate. Any reason for not going
>> that route?
>>
>
> We already know the instruction is stgi, no need to go through the
> guest page tables to fetch it. We do the same thing for all
> instructions for which we have the length and all the information
> necessary to execute it.
Fair enough.
Regards,
Anthony Liguori
>> GIF somehow needs exposure to userspace too, right? Otherwise, when
>> using -no-kernel-apic, userspace may try to inject an interrupt when
>> the guest cannot handle it, right?
>
> Hmm, right, it needs to close the interrupt window.
>
next prev parent reply other threads:[~2008-10-30 19:11 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-20 17:04 [PATCH 0/9] Add support for nested SVM (kernel) v5 Alexander Graf
2008-10-20 17:04 ` [PATCH 1/9] Clean up VINTR setting v5 Alexander Graf
2008-10-20 17:04 ` [PATCH 2/9] Add helper functions for nested SVM v5 Alexander Graf
2008-10-20 17:04 ` [PATCH 3/9] Implement GIF, clgi and stgi v5 Alexander Graf
2008-10-20 17:04 ` [PATCH 4/9] Implement hsave v5 Alexander Graf
2008-10-20 17:04 ` [PATCH 5/9] Add VMLOAD and VMSAVE handlers v5 Alexander Graf
2008-10-20 17:04 ` [PATCH 6/9] Add VMRUN handler v5 Alexander Graf
2008-10-20 17:04 ` [PATCH 7/9] Add VMEXIT handler and intercepts v5 Alexander Graf
2008-10-20 17:04 ` [PATCH 8/9] allow read access to MSR_VM_VR Alexander Graf
2008-10-20 17:04 ` [PATCH 9/9] Allow setting the SVME bit v5 Alexander Graf
2008-10-29 13:58 ` Joerg Roedel
2008-10-29 14:03 ` Alexander Graf
2008-10-29 14:17 ` Avi Kivity
2008-10-29 14:07 ` Avi Kivity
2008-10-30 19:16 ` Anthony Liguori
2008-10-30 19:24 ` Avi Kivity
2008-10-30 20:46 ` Alexander Graf
2008-10-30 20:44 ` Alexander Graf
2008-10-30 20:52 ` Anthony Liguori
2008-11-02 9:11 ` Avi Kivity
2008-11-03 7:37 ` Alexander Graf
2008-11-03 13:54 ` Avi Kivity
2008-10-30 19:15 ` [PATCH 8/9] allow read access to MSR_VM_VR Anthony Liguori
2008-10-31 10:57 ` Joerg Roedel
2008-10-28 18:38 ` Add VMRUN handler v5 Mike Day
2008-10-29 5:35 ` Alexander Graf
2008-11-18 14:14 ` [PATCH 6/9] " Muli Ben-Yehuda
2008-10-30 18:06 ` [PATCH 5/9] Add VMLOAD and VMSAVE handlers v5 Anthony Liguori
2008-10-30 18:44 ` Alexander Graf
2008-10-30 19:14 ` Anthony Liguori
2008-10-30 21:02 ` Alexander Graf
2008-10-30 21:38 ` Anthony Liguori
2008-10-30 18:04 ` [PATCH 4/9] Implement hsave v5 Anthony Liguori
2008-10-30 18:43 ` Alexander Graf
2008-10-30 19:05 ` Anthony Liguori
2008-10-30 19:29 ` Avi Kivity
2008-10-30 20:38 ` Alexander Graf
2008-10-30 20:44 ` Anthony Liguori
2008-10-30 20:47 ` Alexander Graf
2008-10-30 22:05 ` Anthony Liguori
2008-11-02 9:24 ` Avi Kivity
2008-10-27 19:09 ` Implement GIF, clgi and stgi v5 Mike Day
2008-10-27 19:29 ` Avi Kivity
2008-10-27 19:40 ` Mike Day
2008-10-30 18:02 ` [PATCH 3/9] " Anthony Liguori
2008-10-30 18:10 ` Avi Kivity
2008-10-30 18:35 ` Alexander Graf
2008-10-30 19:08 ` Anthony Liguori
2008-10-30 19:11 ` Anthony Liguori [this message]
2008-10-29 13:48 ` [PATCH 2/9] Add helper functions for nested SVM v5 Joerg Roedel
2008-10-30 17:56 ` Anthony Liguori
2008-10-30 18:41 ` Alexander Graf
2008-10-30 19:10 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=490A06DC.5030107@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=agraf@suse.de \
--cc=avi@redhat.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox