From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 9/9] Allow setting the SVME bit v5 Date: Thu, 30 Oct 2008 21:24:07 +0200 Message-ID: <490A09D7.4000704@redhat.com> References: <1224522290-11740-1-git-send-email-agraf@suse.de> <1224522290-11740-2-git-send-email-agraf@suse.de> <1224522290-11740-3-git-send-email-agraf@suse.de> <1224522290-11740-4-git-send-email-agraf@suse.de> <1224522290-11740-5-git-send-email-agraf@suse.de> <1224522290-11740-6-git-send-email-agraf@suse.de> <1224522290-11740-7-git-send-email-agraf@suse.de> <1224522290-11740-8-git-send-email-agraf@suse.de> <1224522290-11740-9-git-send-email-agraf@suse.de> <1224522290-11740-10-git-send-email-agraf@suse.de> <490A0822.4030607@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Alexander Graf , kvm@vger.kernel.org, joro@8bytes.org To: Anthony Liguori Return-path: Received: from mx2.redhat.com ([66.187.237.31]:53177 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753745AbYJ3TYF (ORCPT ); Thu, 30 Oct 2008 15:24:05 -0400 In-Reply-To: <490A0822.4030607@codemonkey.ws> Sender: kvm-owner@vger.kernel.org List-ID: Anthony Liguori wrote: >> +static int nested = 0; >> +module_param(nested, int, S_IRUGO); >> > > Instead of doing this as a module parameter, we could either avoid > advertising SVM support in cpuid from userspace or we could disable > SVM in the BIOS. > > I really like the later approach because it gives a better error > message within the guest. We could also keep the module parameter but > it would be nice to support disabling SVM in userspace too. We do need to expose svme in KVM_GET_SUPPORTED_CPUID, so userspace can enable it if it wants. But I'd like to keep the module parameter (defaulting to off) until this has been tested better. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.