From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 4/9] Implement hsave v5 Date: Thu, 30 Oct 2008 21:29:02 +0200 Message-ID: <490A0AFE.2060202@redhat.com> References: <1224522290-11740-1-git-send-email-agraf@suse.de> <1224522290-11740-2-git-send-email-agraf@suse.de> <1224522290-11740-3-git-send-email-agraf@suse.de> <1224522290-11740-4-git-send-email-agraf@suse.de> <1224522290-11740-5-git-send-email-agraf@suse.de> <4909F71E.2030306@codemonkey.ws> <4C0FB979-99A3-49AD-9AE5-DA2A066DC2E1@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Anthony Liguori , kvm@vger.kernel.org, joro@8bytes.org To: Alexander Graf Return-path: Received: from mx2.redhat.com ([66.187.237.31]:49080 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750741AbYJ3T3D (ORCPT ); Thu, 30 Oct 2008 15:29:03 -0400 In-Reply-To: <4C0FB979-99A3-49AD-9AE5-DA2A066DC2E1@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: Alexander Graf wrote: > > I don't see any benefit from actually exporting that MSR atm. KVM does > never read it and it'd just add additional overhead on every userspace > transition, as it'd need to be synced every time. We only sync MSRs on save/restore. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.