From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH 5/9] Add VMLOAD and VMSAVE handlers v5 Date: Thu, 30 Oct 2008 16:38:16 -0500 Message-ID: <490A2948.5090805@codemonkey.ws> References: <1224522290-11740-1-git-send-email-agraf@suse.de> <1224522290-11740-2-git-send-email-agraf@suse.de> <1224522290-11740-3-git-send-email-agraf@suse.de> <1224522290-11740-4-git-send-email-agraf@suse.de> <1224522290-11740-5-git-send-email-agraf@suse.de> <1224522290-11740-6-git-send-email-agraf@suse.de> <4909F793.4080404@codemonkey.ws> <71E40A19-2D2B-4884-94F6-910363EEE0C4@suse.de> <490A078E.10007@codemonkey.ws> <04372E23-E4BE-427E-9566-A99FB895F338@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, joro@8bytes.org, avi@redhat.com To: Alexander Graf Return-path: Received: from el-out-1112.google.com ([209.85.162.181]:16450 "EHLO el-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752968AbYJ3ViX (ORCPT ); Thu, 30 Oct 2008 17:38:23 -0400 Received: by el-out-1112.google.com with SMTP id z25so466494ele.1 for ; Thu, 30 Oct 2008 14:38:20 -0700 (PDT) In-Reply-To: <04372E23-E4BE-427E-9566-A99FB895F338@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: Alexander Graf wrote: > > On 30.10.2008, at 20:14, Anthony Liguori wrote: > > I don't see this improving code readability, but maybe that again is > just personal preference. Is this a real problem, or just again a > different esthetic view? I'm not wildy opposed to your implementation so I'm perfectly willing to chalk it up to personal preference. Regards, Anthony Liguori > Alex >