From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/1] KVM: Enable Function Level Reset for assigned device Date: Sun, 02 Nov 2008 11:08:44 +0200 Message-ID: <490D6E1C.40504@redhat.com> References: <1225345937-11601-1-git-send-email-sheng@linux.intel.com> <1225427861-27024-1-git-send-email-sheng@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Sheng Yang Return-path: Received: from mx2.redhat.com ([66.187.237.31]:59739 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752839AbYKBJIt (ORCPT ); Sun, 2 Nov 2008 04:08:49 -0500 In-Reply-To: <1225427861-27024-1-git-send-email-sheng@linux.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Sheng Yang wrote: > Ideally, every assigned device should in a clear condition before and after > assignment, so that the former state of device won't affect later work. > Some devices provide a mechanism named Function Level Reset, which is > defined in PCI/PCI-e document. We should execute it before and after device > assignment. > > (But sadly, the feature is new, and most device on the market now don't > support it. We are considering using D0/D3hot transmit to emulate it later, > but not that elegant and reliable as FLR itself.) > > [Update: Reminded by Xiantao, execute FLR after we ensure that the device can > be assigned to the guest.] > > Applied, thanks. -- error compiling committee.c: too many arguments to function