From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 4/9] Implement hsave v5 Date: Sun, 02 Nov 2008 11:24:00 +0200 Message-ID: <490D71B0.8090409@redhat.com> References: <1224522290-11740-1-git-send-email-agraf@suse.de> <1224522290-11740-2-git-send-email-agraf@suse.de> <1224522290-11740-3-git-send-email-agraf@suse.de> <1224522290-11740-4-git-send-email-agraf@suse.de> <1224522290-11740-5-git-send-email-agraf@suse.de> <4909F71E.2030306@codemonkey.ws> <4C0FB979-99A3-49AD-9AE5-DA2A066DC2E1@suse.de> <490A0AFE.2060202@redhat.com> <1797E4C8-3B35-4C40-864C-B410755AF0A2@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Anthony Liguori , kvm@vger.kernel.org, joro@8bytes.org To: Alexander Graf Return-path: Received: from mx2.redhat.com ([66.187.237.31]:59746 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753059AbYKBJYJ (ORCPT ); Sun, 2 Nov 2008 04:24:09 -0500 In-Reply-To: <1797E4C8-3B35-4C40-864C-B410755AF0A2@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: Alexander Graf wrote: > > Oh, really? Looks like I interpreted that code wrong :-). > Nevertheless, we don't use the hsave given by the guest OS, because we > can't trust it. So saving and restoring a non-used value sounds pretty > useless - unless you're migrating from KVM to Qemu. Is this kind of > migration (going to be) possible? Well, at least for testing purposes, it sounds useful. We also can't rule out a guest reading the msr and breaking if the wrong value is found. -- error compiling committee.c: too many arguments to function