From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Patch 4/5] x86_emulator: add the assembler code for three operands Date: Tue, 04 Nov 2008 12:21:30 +0200 Message-ID: <4910222A.20201@redhat.com> References: <20081103160036.499cb482@frecb000711> <20081103160504.3fa8c378@frecb000711> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm To: Guillaume Thouvenin Return-path: Received: from mx2.redhat.com ([66.187.237.31]:33568 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752895AbYKDKWJ (ORCPT ); Tue, 4 Nov 2008 05:22:09 -0500 In-Reply-To: <20081103160504.3fa8c378@frecb000711> Sender: kvm-owner@vger.kernel.org List-ID: Guillaume Thouvenin wrote: > Add the assembler code for three operands > > > +/* Instruction has three operands */ > +/* In the switch we only implement case 4 because we know that for shld instruction > + * bytes are equal to 4. When eveything will be fine, we will add others cases. > No, shld is defined for 16, 32, and 64 bit operands. Need to implement those too. > +#define __emulate_3op(_op,_src,_src2,_dst,_eflags,_by,_bx,_wx,_wy,_lx,_ly,_qx,_qy) \ Since this is not a generic 3 operand implementation, it's better to call this something like __emulate_2op_cl() to give attention to this fact. -- error compiling committee.c: too many arguments to function