From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC Patch 0/5] x86_emulator: emulate shld and shrd instruction Date: Tue, 04 Nov 2008 12:23:22 +0200 Message-ID: <4910229A.1070905@redhat.com> References: <20081103160036.499cb482@frecb000711> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm To: Guillaume Thouvenin Return-path: Received: from mx2.redhat.com ([66.187.237.31]:33592 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753000AbYKDKYA (ORCPT ); Tue, 4 Nov 2008 05:24:00 -0500 In-Reply-To: <20081103160036.499cb482@frecb000711> Sender: kvm-owner@vger.kernel.org List-ID: Guillaume Thouvenin wrote: > This series of patches emulate instructions shld and shrd. As those > instructions have three operands we introduce a decode set for the Src2 > operand. By doing this, the opcode descriptor needs to be extend to 32 > bit. > Other than the missing operand sizes, looks good. -- error compiling committee.c: too many arguments to function