From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] [RFC] Activate VMX on demand Date: Tue, 04 Nov 2008 12:36:30 +0200 Message-ID: <491025AE.1030601@redhat.com> References: <1225729181-24431-1-git-send-email-agraf@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Sander.Vanleeuwen@sun.com, kraxel@redhat.com, anthony@codemonkey.ws, zach@vmware.com To: Alexander Graf Return-path: Received: from mx2.redhat.com ([66.187.237.31]:50591 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753370AbYKDKgj (ORCPT ); Tue, 4 Nov 2008 05:36:39 -0500 In-Reply-To: <1225729181-24431-1-git-send-email-agraf@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: Alexander Graf wrote: > This patch moves the actual VMX enablement from the initialization > of the module to the creation of a VCPU. > > With this approach, KVM can be easily autoloaded and does not block > other VMMs while being modprobe'd. > This improves the user experience a lot, since now other VMMs can > run, even though KVM is loaded, so users do not have to manually > load/unload KVM or any other VMM module. > > Compared to the previously suggested approach "2", which would > introduce a complete framework that brings almost no benefit, > this approach enables coexistence of multiple VMMs without much > intervention. Thanks to Gerd for pointing that out. > > I verified that this approach works with VirtualBox. > > This should be done in x86.c and made to apply to svm as well. Other VMMs would use efer.svme as an indication that svm is in use, similar to cr4.vmxe today. I'm not thrilled about this (it could be done, much more simply, by having the other hypervisor rmmod kvm), but okay. -- error compiling committee.c: too many arguments to function