From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 06/10] KVM: Export ioapic_get_delivery_bitmask Date: Tue, 04 Nov 2008 13:07:19 +0200 Message-ID: <49102CE7.7020401@redhat.com> References: <1225428647-27614-1-git-send-email-sheng@linux.intel.com> <1225428647-27614-7-git-send-email-sheng@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Sheng Yang Return-path: Received: from mx2.redhat.com ([66.187.237.31]:50033 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751314AbYKDLHX (ORCPT ); Tue, 4 Nov 2008 06:07:23 -0500 In-Reply-To: <1225428647-27614-7-git-send-email-sheng@linux.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Sheng Yang wrote: > It would be used for MSI in device assignment, for MSI dispatch. > > -static u32 ioapic_get_delivery_bitmask(struct kvm_ioapic *ioapic, u8 dest, > - u8 dest_mode) > +u32 ioapic_get_delivery_bitmask(struct kvm_ioapic *ioapic, u8 dest, > + u8 dest_mode) > Need to be prefixed with kvm_, otherwise it might be confused with the host ioapic. I'm a little worried about locking; we'll want to have a separate lock for the ioapic, and callers of this function will need to know about it. But we can handle that later. -- error compiling committee.c: too many arguments to function