From: Avi Kivity <avi@redhat.com>
To: Sheng Yang <sheng@linux.intel.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH 08/10] KVM: Add assigned_device_msi_dispatch()
Date: Tue, 04 Nov 2008 13:17:03 +0200 [thread overview]
Message-ID: <49102F2F.4060404@redhat.com> (raw)
In-Reply-To: <1225428647-27614-9-git-send-email-sheng@linux.intel.com>
Sheng Yang wrote:
> The function is used to dispatch MSI to lapic according to MSI message
> address and message data.
>
> (Any way to replace macro GET_VAL_FROM_SHIFT()?)
>
> +#ifdef CONFIG_X86
> +#include <asm/msidef.h>
> +#endif
>
The include can be unconditional.
> +
> +#ifdef CONFIG_X86
> +static void assigned_device_msi_dispatch(struct kvm_assigned_dev_kernel *dev)
> +{
> +#define GET_VAL_FROM_SHIFT(v, s) (((v) & (1 << s)) >> s)
>
test_bit() ?
> + int vcpu_id;
> + struct kvm_vcpu *vcpu;
> + struct kvm_ioapic *ioapic = ioapic_irqchip(dev->kvm);
> + u8 dest_id = (dev->guest_msi_addr & MSI_ADDR_DEST_ID_MASK)
> + >> MSI_ADDR_DEST_ID_SHIFT;
> + u8 vector = (dev->guest_msi_data & MSI_DATA_VECTOR_MASK)
> + >> MSI_DATA_VECTOR_SHIFT;
> + u8 dest_mode = GET_VAL_FROM_SHIFT(dev->guest_msi_addr,
> + MSI_ADDR_DEST_MODE_SHIFT);
> + u8 trig_mode = GET_VAL_FROM_SHIFT(dev->guest_msi_data,
> + MSI_DATA_TRIGGER_SHIFT);
> + u8 delivery_mode = GET_VAL_FROM_SHIFT(dev->guest_msi_data,
> + MSI_DATA_DELIVERY_MODE_SHIFT);
>
int is usually better than u8.
> + u32 deliver_bitmask;
> +
> + case MSI_DATA_DELIVERY_FIXED_VAL:
> + for (vcpu_id = 0; deliver_bitmask != 0; vcpu_id++) {
>
__ffs() and __clear_bit() can make this a bit faster. Can be done later
though.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-11-04 11:17 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-31 4:50 [PATCH 0/10][v4] Enable MSI for KVM assigned device kernel part Sheng Yang
2008-10-31 4:50 ` [PATCH 01/10] KVM: Move ack notifier register and IRQ sourcd ID request Sheng Yang
2008-10-31 4:50 ` [PATCH 02/10] KVM: Separate update irq to a single function Sheng Yang
2008-10-31 4:50 ` [PATCH 03/10] KVM: Replace irq_requested with more generic irq_requested_type Sheng Yang
2008-10-31 4:50 ` [PATCH 04/10] KVM: Clean up assigned_device_update_irq Sheng Yang
2008-10-31 4:50 ` [PATCH 05/10] KVM: Add fields for MSI device assignment Sheng Yang
2008-11-04 11:05 ` Avi Kivity
2008-10-31 4:50 ` [PATCH 06/10] KVM: Export ioapic_get_delivery_bitmask Sheng Yang
2008-11-04 11:07 ` Avi Kivity
2008-11-04 11:09 ` Sheng Yang
2008-10-31 4:50 ` [PATCH 07/10] x86: Add MSI delivery mode value Sheng Yang
2008-11-04 11:09 ` Avi Kivity
2008-11-04 11:37 ` Sheng Yang
2008-10-31 4:50 ` [PATCH 08/10] KVM: Add assigned_device_msi_dispatch() Sheng Yang
2008-11-04 11:17 ` Avi Kivity [this message]
2008-11-04 11:17 ` Sheng Yang
2008-10-31 4:50 ` [PATCH 09/10] KVM: Enable MSI for device assignment Sheng Yang
2008-11-04 11:23 ` Avi Kivity
2008-11-04 13:25 ` Sheng Yang
2008-11-04 13:32 ` Avi Kivity
2008-11-04 13:58 ` Sheng Yang
2008-11-04 14:35 ` Avi Kivity
2008-11-04 14:57 ` Sheng Yang
2008-11-04 15:01 ` Avi Kivity
2008-11-04 15:14 ` Sheng Yang
2008-10-31 4:50 ` [PATCH 10/10] KVM: MSI to INTx translate Sheng Yang
2008-11-04 11:25 ` Avi Kivity
2008-11-04 11:40 ` Sheng Yang
2008-11-04 11:57 ` Avi Kivity
2008-11-04 12:55 ` Sheng Yang
-- strict thread matches above, loose matches on Subject: below --
2008-10-30 8:20 [RFC][PATCH 0/10][v3] Enable MSI for KVM assigned device Sheng Yang
2008-10-30 8:20 ` [PATCH 08/10] KVM: Add assigned_device_msi_dispatch() Sheng Yang
2008-10-30 8:56 ` Sheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49102F2F.4060404@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox