From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH 08/10] KVM: Add assigned_device_msi_dispatch()
Date: Tue, 04 Nov 2008 13:17:03 +0200
Message-ID: <49102F2F.4060404@redhat.com>
References: <1225428647-27614-1-git-send-email-sheng@linux.intel.com> <1225428647-27614-9-git-send-email-sheng@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org
To: Sheng Yang <sheng@linux.intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:56129 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751776AbYKDLRG (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 4 Nov 2008 06:17:06 -0500
In-Reply-To: <1225428647-27614-9-git-send-email-sheng@linux.intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Sheng Yang wrote:
> The function is used to dispatch MSI to lapic according to MSI message
> address and message data.
>
> (Any way to replace macro GET_VAL_FROM_SHIFT()?)
>   

> +#ifdef CONFIG_X86
> +#include <asm/msidef.h>
> +#endif
>   

The include can be unconditional.

> +
> +#ifdef CONFIG_X86
> +static void assigned_device_msi_dispatch(struct kvm_assigned_dev_kernel *dev)
> +{
> +#define GET_VAL_FROM_SHIFT(v, s) (((v) & (1 << s)) >> s)
>   

test_bit() ?

> +	int vcpu_id;
> +	struct kvm_vcpu *vcpu;
> +	struct kvm_ioapic *ioapic = ioapic_irqchip(dev->kvm);
> +	u8 dest_id = (dev->guest_msi_addr & MSI_ADDR_DEST_ID_MASK)
> +			>> MSI_ADDR_DEST_ID_SHIFT;
> +	u8 vector = (dev->guest_msi_data & MSI_DATA_VECTOR_MASK)
> +			>> MSI_DATA_VECTOR_SHIFT;
> +	u8 dest_mode = GET_VAL_FROM_SHIFT(dev->guest_msi_addr,
> +					  MSI_ADDR_DEST_MODE_SHIFT);
> +	u8 trig_mode = GET_VAL_FROM_SHIFT(dev->guest_msi_data,
> +					  MSI_DATA_TRIGGER_SHIFT);
> +	u8 delivery_mode = GET_VAL_FROM_SHIFT(dev->guest_msi_data,
> +					  MSI_DATA_DELIVERY_MODE_SHIFT);
>   

int is usually better than u8.

> +	u32 deliver_bitmask;
> +
> +	case MSI_DATA_DELIVERY_FIXED_VAL:
> +		for (vcpu_id = 0; deliver_bitmask != 0; vcpu_id++) {
>   

__ffs() and __clear_bit() can make this a bit faster.  Can be done later 
though.

-- 
error compiling committee.c: too many arguments to function