From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 6/6] kvm: qemu: virtio-net: drop mutex during tx tapfd write Date: Tue, 04 Nov 2008 13:43:58 +0200 Message-ID: <4910357E.1040902@redhat.com> References: <> <1225389113-28332-1-git-send-email-markmc@redhat.com> <1225389113-28332-2-git-send-email-markmc@redhat.com> <1225389113-28332-3-git-send-email-markmc@redhat.com> <1225389113-28332-4-git-send-email-markmc@redhat.com> <1225389113-28332-5-git-send-email-markmc@redhat.com> <1225389113-28332-6-git-send-email-markmc@redhat.com> <1225389113-28332-7-git-send-email-markmc@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Avi Kivity , kvm@vger.kernel.org To: Mark McLoughlin Return-path: Received: from mx2.redhat.com ([66.187.237.31]:48566 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751154AbYKDLoC (ORCPT ); Tue, 4 Nov 2008 06:44:02 -0500 In-Reply-To: <1225389113-28332-7-git-send-email-markmc@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Mark McLoughlin wrote: > This allows the guest vcpu thread to exit while the I/O thread is > churning away. > > > + kvm_sleep_begin(); > What if the nic is hot-unplugged here? > len += qemu_sendv_packet(n->vc, out_sg, out_num); > n is freed, no? > + kvm_sleep_end(); > > -- error compiling committee.c: too many arguments to function