public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Sheng Yang <sheng@linux.intel.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH 10/10] KVM: MSI to INTx translate
Date: Tue, 04 Nov 2008 13:57:56 +0200	[thread overview]
Message-ID: <491038C4.3040206@redhat.com> (raw)
In-Reply-To: <200811041940.07596.sheng@linux.intel.com>

Sheng Yang wrote:
> Yes, in theory, we got a little trouble, but not that much.
>
> The mechanism based on a assumption: every time guest got a interrupt, it 
> would deassert the interrupt source sooner or later. So we take the Ack action 
> as the same as deassert the IRQ line here (unmasked the IRQ).
>
> So the biggest known issue is, after guest got the interrupt, rather than 
> deassert it, guest driver took the advantage of level triggered interrupt, and 
> just want to deassert after it receive it for e.g. 10 times. Then we would got 
> the trouble. But it's so tricky and we don't know any device by now take this 
> way yet. Of course they can, so we also suggest to use a whitelist/blacklist 
> for this approach. But this should work in most condition.
>
> Yeah, it's aggressive, but we think it's reasonable, and tested OK (in my 
> limited environment). Also I heard that Hyper-V or Vmware did this.
>
> Any more concerns? Hope we didn't neglect something.
>   

Please add a module parameter to disable msi->pciirq conversion in that 
case.  So if someone runs into trouble, we can try out the alternative.

-- 
error compiling committee.c: too many arguments to function


  reply	other threads:[~2008-11-04 11:57 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-31  4:50 [PATCH 0/10][v4] Enable MSI for KVM assigned device kernel part Sheng Yang
2008-10-31  4:50 ` [PATCH 01/10] KVM: Move ack notifier register and IRQ sourcd ID request Sheng Yang
2008-10-31  4:50 ` [PATCH 02/10] KVM: Separate update irq to a single function Sheng Yang
2008-10-31  4:50 ` [PATCH 03/10] KVM: Replace irq_requested with more generic irq_requested_type Sheng Yang
2008-10-31  4:50 ` [PATCH 04/10] KVM: Clean up assigned_device_update_irq Sheng Yang
2008-10-31  4:50 ` [PATCH 05/10] KVM: Add fields for MSI device assignment Sheng Yang
2008-11-04 11:05   ` Avi Kivity
2008-10-31  4:50 ` [PATCH 06/10] KVM: Export ioapic_get_delivery_bitmask Sheng Yang
2008-11-04 11:07   ` Avi Kivity
2008-11-04 11:09     ` Sheng Yang
2008-10-31  4:50 ` [PATCH 07/10] x86: Add MSI delivery mode value Sheng Yang
2008-11-04 11:09   ` Avi Kivity
2008-11-04 11:37     ` Sheng Yang
2008-10-31  4:50 ` [PATCH 08/10] KVM: Add assigned_device_msi_dispatch() Sheng Yang
2008-11-04 11:17   ` Avi Kivity
2008-11-04 11:17     ` Sheng Yang
2008-10-31  4:50 ` [PATCH 09/10] KVM: Enable MSI for device assignment Sheng Yang
2008-11-04 11:23   ` Avi Kivity
2008-11-04 13:25     ` Sheng Yang
2008-11-04 13:32       ` Avi Kivity
2008-11-04 13:58         ` Sheng Yang
2008-11-04 14:35           ` Avi Kivity
2008-11-04 14:57             ` Sheng Yang
2008-11-04 15:01               ` Avi Kivity
2008-11-04 15:14                 ` Sheng Yang
2008-10-31  4:50 ` [PATCH 10/10] KVM: MSI to INTx translate Sheng Yang
2008-11-04 11:25   ` Avi Kivity
2008-11-04 11:40     ` Sheng Yang
2008-11-04 11:57       ` Avi Kivity [this message]
2008-11-04 12:55         ` Sheng Yang
  -- strict thread matches above, loose matches on Subject: below --
2008-10-30  8:20 [RFC][PATCH 0/10][v3] Enable MSI for KVM assigned device Sheng Yang
2008-10-30  8:20 ` [PATCH 10/10] KVM: MSI to INTx translate Sheng Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=491038C4.3040206@redhat.com \
    --to=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=sheng@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox