From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <aliguori@us.ibm.com>
Subject: Re: [PATCH 3/3] Add KVM support to QEMU
Date: Tue, 04 Nov 2008 08:02:33 -0600
Message-ID: <491055F9.60802@us.ibm.com>
References: <1225224814-9875-1-git-send-email-aliguori@us.ibm.com> <1225224814-9875-2-git-send-email-aliguori@us.ibm.com> <1225224814-9875-3-git-send-email-aliguori@us.ibm.com> <49104D1F.1020905@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: qemu-devel@nongnu.org, Glauber Costa <glommer@redhat.com>,
	kvm-devel <kvm@vger.kernel.org>
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from e2.ny.us.ibm.com ([32.97.182.142]:43222 "EHLO e2.ny.us.ibm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751662AbYKDOCj (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 4 Nov 2008 09:02:39 -0500
Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234])
	by e2.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id mA4E2clH023653
	for <kvm@vger.kernel.org>; Tue, 4 Nov 2008 09:02:38 -0500
Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64])
	by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id mA4E2c9c120236
	for <kvm@vger.kernel.org>; Tue, 4 Nov 2008 09:02:38 -0500
Received: from d01av04.pok.ibm.com (loopback [127.0.0.1])
	by d01av04.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id mA4E2bPS025606
	for <kvm@vger.kernel.org>; Tue, 4 Nov 2008 09:02:38 -0500
In-Reply-To: <49104D1F.1020905@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Avi Kivity wrote:
>>
>> +8) Merge in additional changes in kvm-userspace tree
>>   
>
> One of the important changes is running with signal delivery disabled, 
> since that's particularly slow (requires save/restore of the floating 
> point state, for example).

I think we need the IO thread first.  We're slowly getting there

>> +
>> +typedef struct kvm_userspace_memory_region KVMSlot;
>>   
>
> KVMMemorySlot?

Sure.

>> +
>> +static KVMState *kvm_state;
>>   
>
> Why a pointer?

I would like to avoid having the global state to begin with.

>> +    if (ret < 0) {
>> +        dprintf("kvm_create_vcpu failed\n");
>>   
>
> showing errno would be nice.

Indeed.

>> +
>> +static void kvm_getput_reg(__u64 *kvm_reg, target_ulong *qemu_reg, 
>> int set)
>> +{
>> +    if (set)
>> +        *kvm_reg = *qemu_reg;
>> +    else
>> +        *qemu_reg = *kvm_reg;
>> +}
>>   
>
> Ugh.
>
> I think live migration is now broken, since kvm accesses will not 
> update the qemu dirty bitmap.

Eh?  I don't follow you here.

Regards,

Anthony Liguori