From: Avi Kivity <avi@redhat.com>
To: Glauber Costa <glommer@gmail.com>
Cc: Jes Sorensen <jes@sgi.com>, Anthony Liguori <aliguori@us.ibm.com>,
Hollis Blanchard <hollisb@us.ibm.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"kvm-ia64@vger.kernel.org" <kvm-ia64@vger.kernel.org>
Subject: Re: [patch] remove vcpu_info array v5
Date: Tue, 04 Nov 2008 16:30:45 +0200 [thread overview]
Message-ID: <49105C95.90809@redhat.com> (raw)
In-Reply-To: <5d6222a80811040555q5be67439sbd38d94dfa25d8ad@mail.gmail.com>
Glauber Costa wrote:
>> This can't be the best way of determining the env pointer from a cpu number.
>>
> By far it is not. But at least it does not depend on any kvm-specific
> data, and works
> for both qemu and kvm. So it's better to be this way.
>
> If we change this scheme to a better one, like a hash table, then
> it'll improve both qemu and kvm.
>
>
There are simpler data structures. An example is an array. Since we
have an upper limit on the number of cpus (->max_cpus) there are no
issues with scaling (unlike with the algorithm above).
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-11-04 14:30 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-30 14:09 [patch] remove vcpu_info array v5 Jes Sorensen
2008-11-04 11:54 ` Avi Kivity
2008-11-04 13:55 ` Glauber Costa
2008-11-04 14:30 ` Avi Kivity [this message]
2008-11-04 14:35 ` Glauber Costa
2008-11-04 14:40 ` Avi Kivity
2008-11-04 14:43 ` Glauber Costa
2008-11-04 14:47 ` Avi Kivity
2008-11-10 13:30 ` Jes Sorensen
2008-11-10 13:40 ` Avi Kivity
2008-11-10 15:22 ` Anthony Liguori
2008-11-10 15:45 ` Avi Kivity
2008-11-10 15:47 ` Jes Sorensen
2008-11-10 15:54 ` Avi Kivity
2008-11-10 15:58 ` Jes Sorensen
2008-11-11 9:26 ` Avi Kivity
2008-11-12 13:02 ` Jes Sorensen
2008-11-12 13:09 ` Glauber Costa
2008-11-12 13:14 ` Avi Kivity
2008-11-12 13:12 ` Avi Kivity
2008-11-10 12:30 ` Jes Sorensen
2008-11-10 13:24 ` Jes Sorensen
2008-11-10 13:48 ` Avi Kivity
2008-11-13 16:46 ` [patch] pass opague CPUState through libkvm instead of int vcpu Jes Sorensen
2008-11-18 12:55 ` Avi Kivity
2008-11-18 12:59 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49105C95.90809@redhat.com \
--to=avi@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=glommer@gmail.com \
--cc=hollisb@us.ibm.com \
--cc=jes@sgi.com \
--cc=kvm-ia64@vger.kernel.org \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox