From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 3/3] Add KVM support to QEMU Date: Tue, 04 Nov 2008 16:46:03 +0200 Message-ID: <4910602B.5060101@redhat.com> References: <1225224814-9875-1-git-send-email-aliguori@us.ibm.com> <1225224814-9875-2-git-send-email-aliguori@us.ibm.com> <1225224814-9875-3-git-send-email-aliguori@us.ibm.com> <49104D1F.1020905@redhat.com> <491055F9.60802@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, Glauber Costa , kvm-devel To: Anthony Liguori Return-path: Received: from mx2.redhat.com ([66.187.237.31]:47832 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751915AbYKDOqL (ORCPT ); Tue, 4 Nov 2008 09:46:11 -0500 In-Reply-To: <491055F9.60802@us.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: Anthony Liguori wrote: >> I think live migration is now broken, since kvm accesses will not >> update the qemu dirty bitmap. > > Eh? I don't follow you here. > guest writes in qemu set the qemu dirty bitmap (for cpu_physical_memory_get_dirty()), but guest accesses in kvm won't, unless you enable dirty tracking and synchronize kvm's bitmap to qemu's. See the changes to migration.c in kvm's qemu. -- error compiling committee.c: too many arguments to function