From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Activate Virtualization On Demand v2 Date: Wed, 05 Nov 2008 15:12:29 +0200 Message-ID: <49119BBD.9080106@redhat.com> References: <1225874896-13186-1-git-send-email-agraf@suse.de> <200811051406.34227.borntraeger@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Alexander Graf , kvm@vger.kernel.org, kraxel@redhat.com, anthony@codemonkey.ws, Sander.Vanleeuwen@sun.com, zach@vmware.com, brogers@novell.com To: Christian Borntraeger Return-path: Received: from mx2.redhat.com ([66.187.237.31]:32912 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751869AbYKENN5 (ORCPT ); Wed, 5 Nov 2008 08:13:57 -0500 In-Reply-To: <200811051406.34227.borntraeger@de.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: Christian Borntraeger wrote: > When you are at it, could move these printk to the arches that atually > enable/disable virtualization? > > For example you could do something like > if (callback) { > printk "..."; > callback(); > } > > And then you could remove kvm_arch_hardware_enable/disable from s390 and > powerpc. > > Havng these messages on s390 and powerpc makes absolutely no sense. > In a separate patch, this is big enough already. We could do this using kconfig config KVM_NEEDS_HARDWARE_DETECT bool default n and override it for x86/ia64. This would remove the need to implement dummy callbacks in s390/ppc. -- error compiling committee.c: too many arguments to function