From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch 2] thread/core siblings info for guests Date: Thu, 06 Nov 2008 15:18:56 +0200 Message-ID: <4912EEC0.2020605@redhat.com> References: <8EA2C2C4116BF44AB370468FBF85A7779B418DEF@orsmsx504.amr.corp.intel.com> <48E88C62.9030103@redhat.com> <1224283519.18637.23.camel@lnitindesktop.sc.intel.com> <48FAFE0B.5030209@redhat.com> <1225471648.1521.7.camel@lnitindesktop.sc.intel.com> <49106364.1070909@redhat.com> <1225825339.23171.25.camel@lnitindesktop.sc.intel.com> <49113F82.5050409@redhat.com> <1225929381.18973.7.camel@lnitindesktop.sc.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Nakajima, Jun" , "kvm@vger.kernel.org" , "kraxel@redhat.com" , "chrisw@sous-sol.org" To: nitin.a.kamble@intel.com Return-path: Received: from mx2.redhat.com ([66.187.237.31]:35169 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753048AbYKFNTD (ORCPT ); Thu, 6 Nov 2008 08:19:03 -0500 In-Reply-To: <1225929381.18973.7.camel@lnitindesktop.sc.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Nitin A Kamble wrote: > Hi Avi, > This patches the 2nd bug in the kernel code. > > The code to traverse the cpuid data array list for counting type of > leaves is currently broken. > This patches fixes the 2 things in it. > 1. Set the 1st counting entry's flag KVM_CPUID_FLAG_STATE_READ_NEXT. > Without it the code will never find a valid entry. > 2. Also the stop condition in the for loop while looking for the > next unflaged entry is broken. It needs to stop when it find one > matching entry; and in the case of count of 1, it will be the same > entry found in this iteration. > > Applied, thanks. -- error compiling committee.c: too many arguments to function