From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: KVM_CAP_DEVICE_ASSIGNMENT should depend on CONFIG_PCI
Date: Thu, 06 Nov 2008 18:13:01 +0200
Message-ID: <4913178D.8010008@redhat.com>
References: <e4de053b0811021454y2084e79cq6c666fa9cb04776f@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1;
	format=flowed
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: KVM List <kvm@vger.kernel.org>
To: =?ISO-8859-1?Q?Daniel_God=E1s?= <dgodas@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:38207 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752588AbYKFQNG (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 6 Nov 2008 11:13:06 -0500
In-Reply-To: <e4de053b0811021454y2084e79cq6c666fa9cb04776f@mail.gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Daniel God=E1s wrote:
> Hello,
>
> if you compile the kernel with KVM activated and without PCI support
> you get the following crash:
>
>   CC      arch/x86/kvm/../../../virt/kvm/kvm_main.o
> arch/x86/kvm/../../../virt/kvm/kvm_main.c: In function
> 'kvm_free_assigned_device':
> arch/x86/kvm/../../../virt/kvm/kvm_main.c:155: error: implicit
> declaration of function 'pci_reset_function'
> make[1]: *** [arch/x86/kvm/../../../virt/kvm/kvm_main.o] Error 1
> make: *** [arch/x86/kvm] Error 2
>
> This can be reproduced by using the attached config file. Obviously
> the pci_reset_function should not be called when PCI support is
> disabled. These changes fix the issue:
>  =20

I made KVM/x86 depend on PCI.  If someone wants to run kvm on a non-pci=
=20
x86 host, we (they) can refactor it.

--=20
error compiling committee.c: too many arguments to function