From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: preempt.c not in hack-files
Date: Thu, 06 Nov 2008 18:34:01 +0200
Message-ID: <49131C79.2000107@redhat.com>
References: <CD604D1B-76D6-450E-A0AF-DA85F60C86CB@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: KVM list <kvm@vger.kernel.org>
To: Alexander Graf <agraf@suse.de>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:45158 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750910AbYKFQeH (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 6 Nov 2008 11:34:07 -0500
In-Reply-To: <CD604D1B-76D6-450E-A0AF-DA85F60C86CB@suse.de>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Alexander Graf wrote:
> Hi,
>
> is there any particular reason x86/preempt.c is not in the hack-files? 

Mainly because it doesn't come from kvm.git.

> When I accidently tried to compile KVM on a kernel that does not have 
> PREEMPT_NOTIFIERS, I got an error claiming that "on_each_cpu" is wrong.
>
> So basically we should use kvm_on_each_cpu here, right?

Yes, that's probably the best thing to do.


-- 
error compiling committee.c: too many arguments to function